Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /composer.lock #2688

Closed
weitzman opened this issue Mar 23, 2017 · 2 comments
Closed

Remove /composer.lock #2688

weitzman opened this issue Mar 23, 2017 · 2 comments

Comments

@weitzman
Copy link
Member

weitzman commented Mar 23, 2017

Now that Drush (master) only operates as a dependency in a bigger project, we can remove /composer.lock. Thats not used for dependencies - only the project's top level composer.lock is used. See https://getcomposer.org/doc/02-libraries.md#lock-file.

Any objections?

@weitzman weitzman changed the title Remove composer.lock Remove /composer.lock Mar 23, 2017
@greg-1-anderson
Copy link
Member

Yes, I agree that the composer.lock is of little use here.

mikeker pushed a commit to mikeker/drush that referenced this issue Aug 10, 2017
@glennpratt
Copy link
Contributor

@weitzman I'm hearing via third party that for some purposes we should still install drush globally, but without a lock file, I'll have to fork to create stable build. Is that basically the sum of it?

IMO, committing a lock file is just better, even for libs, regardless of language/tool. If you want a test that blows up as your dependencies flap in the wind, make a secondary test that deletes the lock file before it starts so you can isolate the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants