Remove drupal.js from D8 root check.

[stefanruijsenaars]

No description provided.

[stefanruijsenaars]

See #1105

[greg-1-anderson]

The problem here is that we've weakened the Drush boostrap, making false positives more likely. Without drupal.js, none of the files we check contain the name "drupal" any longer.

I see two good ways to move forward (lacking an official way to detect the root, as mentioned in #1105):

1. Temporarily remove drupal.js from the bootstrap test. Put it back in later, once file locations are stable. Add a comment with the new location, and a TODO to put the check back in later.
2. Check for both the new and the old location of drupal.js. Put in a comment to remove the old location once we are ready to de-support old Drupal 8 betas (maybe after Drupal 8 stable release).

I'd slightly prefer #2.

[stefanruijsenaars]

#2 seem good to me. It looks like the new location will be core/assets/js/drupal.js

[stefanruijsenaars]

Updated the pull request to check for both locations.

[greg-1-anderson]

Looks good. Thanks.

[stefanruijsenaars]

Thanks. Can we do a new Drush release so this can be installed on
qa.drupal.org?

2015-02-09 15:56 GMT+01:00 Greg Anderson notifications@github.com:

Merged #1106 #1106.

—
Reply to this email directly or view it on GitHub
#1106 (comment).

[greg-1-anderson]

Seems reasonable. Discussion on releases is in #1123.