Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config-export --skip-hashes #2630

Closed
wants to merge 3 commits into from
Closed

config-export --skip-hashes #2630

wants to merge 3 commits into from

Conversation

nevergone
Copy link
Contributor

Issue #2197

@greg-1-anderson
Copy link
Member

+1 LGTM; tests sure would be nice.

@weitzman
Copy link
Member

I'd like to see how the config_split integration finalizes before merging this.

@bircher
Copy link
Contributor

bircher commented Feb 23, 2017

config_split will work as long as the read/write interaction happens with the config.storage.sync, so it would work too.
But of course this functionality could also be achieved with a ConfigFilter from the config_filter module (which is a dependency for the next config_split release)

@weitzman
Copy link
Member

Lets rely on config_filter instead of coding it here. Hope thats OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants