Fix #2658: Run invalidateContainer() only when needed #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I'm not a big expert in running tests, so haven't launched them locally :-/ |
|
Only one 'make' test failing here. Probably a spurious failure; I restarted that one test. |
|
Failed the same way -- although I can download the file on my local system just fine. Note that |
|
I re-ran the last failed job and now the PR is green. Unless @greg-1-anderson objects in the next day or two, I'm inclined to merge this. |
weitzman
changed the title
|
Figured it would eventually turn green. I am strongly in favor of this change. We should do the same on the |
weitzman
pushed a commit
that referenced
this pull request
Mar 10, 2017
mikeker
pushed a commit
to mikeker/drush
that referenced
this pull request
Aug 10, 2017
…-ops#2663) # Conflicts: # lib/Drush/Drupal/DrushServiceModfier.php # lib/Drush/Drupal/DrushServiceModifier.php # src/Drupal/DrushServiceModfier.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.