Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had noticed that launching
drush php
is often inexplicably slow, taking up to 30 seconds to launch. I've now discovered that this happens when I am on a slow mobile connection. PsySH has a feature to check for updates, and by default this checks once per week. Unfortunately since we are using a "bundled" version and generate the configuration on the fly when launching it this performs the update check every single time it is launched.I can understand the usefulness of this feature when using PsySH standalone, but I think this version check is pretty pointless in our typical use case. PsySH is a dependency of Drush which is a dev dependency of Drupal which is a dependency of a custom web project which will typically only be updated whenever a security update is available. I don't think most maintainers of Drupal sites are going to jump at the opportunity to update their production instances just because this niche developer tool has a new update 😛
I had a look to port this to the master branch too but it was not immediately clear to me where the PsySH configuration was being generated.