Factor out fallback dt() code into StringUtils::interpolate(). #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-1-anderson
force-pushed
the
interpolate
branch
from
3e4ed3d
to
94a613f
Compare
weitzman
approved these changes
Jul 28, 2017
| @@ -28,4 +28,41 @@ public static function csvToArray($args) | |||
| // | |||
| return array_map('trim', array_filter(explode(',', is_array($args) ? implode(',', $args) : $args))); | |||
| } | |||
|
|
|||
| /** | |||
| * Replace placeholders in a string. | |||
There was a problem hiding this comment.
Approved. Ideally we add @param annotations to the new method. (I feel odd asking the annotation maintainer about annotations)
There was a problem hiding this comment.
lol np. I'll go back and annotate the other PR too. I often procrastinate on this when parameters are in flux, but that can lead to never doing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple refactor, for rebasing into the Symfony Dispatch PR.