Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle --yes and --debug #2927

Merged
merged 4 commits into from
Sep 3, 2017
Merged

Conversation

weitzman
Copy link
Member

@weitzman weitzman commented Sep 2, 2017

  1. --yes behaves like --no-interaction. The effect is that prompts just proceed with defaults. At this time we lose Drush's feature to print out the question and response even during a --yes request. --no is still not supported.
  2. --debug maps to -vv. Folks wanting more should use -vvv which maps pretty well to Drush's old DEBUG_NOTIFY level.

The new code in Preflight.php could easily be moved elsewhere if anyone has thoughts on that.

}
// Use -vvv for even more verbose logging.
if ($input->getParameterOption(['--debug', '-d'], false, true)) {
$output->setVerbosity(Output::VERBOSITY_VERBOSE);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERBOSITY_VERBOSE is -v. VERBOSITY_VERY_VERBOSE is -vv. VERBOSITY_DEBUG is -vvv. I think we should use VERBOSITY_DEBUG here.

Copy link
Member

@greg-1-anderson greg-1-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weitzman weitzman merged commit b92831b into symfony-dispatch Sep 3, 2017
@weitzman weitzman deleted the symfony-dispatch-global-options branch September 3, 2017 13:11
greg-1-anderson pushed a commit that referenced this pull request Sep 14, 2017
weitzman added a commit to weitzman/drush that referenced this pull request Dec 15, 2021
weitzman added a commit that referenced this pull request Dec 15, 2021
* Fix #2927. Don't issue a login link if user is blocked.

* Add name in err msg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants