Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take default value for --sites-subdir in site install command #2982

Merged
merged 2 commits into from
Sep 29, 2017

Conversation

greg-1-anderson
Copy link
Member

This will be done only if the URI is a simple identifier (e.g. "dev" or "stage"), or if stripping the http:// off the head of the URI results in the name of a folder in sites that already exists.

Continuation of #2981

@weitzman
Copy link
Member

This looks like an improvement. Thanks for looking into this tangled code. I removed it hastily in 20749fb#diff-ca1bf65048418d6ca1d1d82c13f88eb7. Perhaps you could look at that function and see if we are replacing what we need to replace. In particular we should load sites.php and respect it during install and re-install.

@greg-1-anderson
Copy link
Member Author

Yes, I reviewed that function last night, but I missed the support for sites.php. I'm going to merge this now and add support for that in a follow-on pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants