Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unescaped quotes in Node titles breaks storybook #438

Closed
Decipher opened this issue Feb 8, 2022 · 0 comments · Fixed by #439
Closed

Unescaped quotes in Node titles breaks storybook #438

Decipher opened this issue Feb 8, 2022 · 0 comments · Fixed by #439
Labels
bug Something isn't working module: entity Related to the `druxt-entity` module

Comments

@Decipher
Copy link
Member

Decipher commented Feb 8, 2022

Describe the bug
If a node as an unescaped quote (" or ') in the title it breaks the storybook integration.

To Reproduce
N/A

Expected behavior
Quotes should be escaped.

Media
N/A

Your Environment (please complete the following information):
N/A

Additional context
N/A
@Decipher Decipher added bug Something isn't working module: entity Related to the `druxt-entity` module labels Feb 8, 2022
Decipher added a commit that referenced this issue Feb 8, 2022
@Decipher
fix(#438): add escaping to story title
aa5a7f0
@Decipher Decipher mentioned this issue Feb 8, 2022
Merged
7 tasks
Decipher added a commit that referenced this issue Feb 10, 2022
@Decipher
fix(#438): add escaping to story title
8b0c6f7
Decipher added a commit that referenced this issue Feb 10, 2022
@Decipher
fix(#438): add escaping to story title
de0875a
Decipher added a commit that referenced this issue Feb 10, 2022
@Decipher
fix(#438): add escaping to story title (#439)
d65eb40
Decipher added a commit that referenced this issue Aug 7, 2022
@Decipher
chore(#438): add examples documentation
0c6cad9
Decipher added a commit that referenced this issue Aug 9, 2022
@Decipher
feat(#458): Add DruxtAuth to DruxtSite example (#547)
072a715 
* feat(#458): add auth modules and configuration

* chore(#458): update example auth

* chore(#458): add default docs .env

* chore(#546): add druxt-site example message

* chore(#438): add examples documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working module: entity Related to the `druxt-entity` module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#438): add escaping to story title druxt/druxt.js
1 participant
@Decipher