Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook integration bug with @nuxtjs/storybook@4.3.0 #464

Closed
Tracked by #474
, #480 ,  #529
...
Decipher opened this issue Mar 6, 2022 · 1 comment · Fixed by #467
Closed
Tracked by #474
, #480 ,  #529
...

Storybook integration bug with @nuxtjs/storybook@4.3.0 #464

Decipher opened this issue Mar 6, 2022 · 1 comment · Fixed by #467
Labels
blocked Issue is currently blocked bug Something isn't working
Milestone
1.0.0

Comments

@Decipher
Copy link
Member

Decipher commented Mar 6, 2022 •
edited
Loading

Describe the bug
Druxt storybook integration fails when using the latest version of @nuxtjs/storybook

To Reproduce
Steps to reproduce the behavior:

  1. Setup DruxtSite with @nuxtjs/storybook@^4.3.0: https://gitpod.io/#https://github.com/druxt/demo.druxtjs.org/pull/409
  2. Run npx nuxt storybook
  3. Wait
  4. See error

Expected behavior
No error, storybook should work.

Media
image

Your Environment (please complete the following information):

  • Device: N/A
  • OS: N/A
  • Browser N/A
  • Version N/A

Additional context
There are two causes of this issue:

The other Druxt module use templates to add the stories, which works fine with Nuxt Storybook 4.3.x:
@Decipher Decipher added the bug Something isn't working label Mar 6, 2022
Decipher added a commit that referenced this issue Mar 6, 2022
@Decipher
fix(#464): update breadcrumb story setup
f5c4d77
Decipher added a commit that referenced this issue Mar 6, 2022
@Decipher
fix(#464): update druxt stories
48a4386
Decipher added a commit that referenced this issue Mar 7, 2022
@Decipher
fix(#464): update breadcrumb story setup
875081c
Decipher added a commit that referenced this issue Mar 7, 2022
@Decipher
fix(#464): update druxt stories
999e47c
Decipher added a commit that referenced this issue Mar 7, 2022
@Decipher
chore(#464): update story description
48a9bff
@Decipher Decipher mentioned this issue Mar 7, 2022
Merged
7 tasks
Decipher added a commit that referenced this issue Mar 7, 2022
@Decipher
chore(#464): add changeset
a7bea20
Decipher added a commit that referenced this issue Mar 7, 2022
@Decipher
chore(#464): fix broken test
a6ad1a3
@Decipher
Copy link
Member Author

Decipher commented Mar 7, 2022

Blocked by nuxt-modules/storybook#373

@Decipher Decipher mentioned this issue Mar 8, 2022
Closed
12 tasks
@Decipher Decipher added the blocked Issue is currently blocked label Mar 9, 2022
@Decipher Decipher mentioned this issue Mar 15, 2022
Closed
13 tasks
@Decipher Decipher mentioned this issue Apr 18, 2022
Closed
@Decipher Decipher mentioned this issue Apr 26, 2022
Closed
13 tasks
This was referenced May 10, 2022
Closed
Closed
@Decipher Decipher added this to the 1.0.0 milestone May 24, 2022
@Decipher Decipher mentioned this issue May 24, 2022
Closed
16 tasks
@Decipher Decipher mentioned this issue May 31, 2022
Closed
15 tasks
@Decipher Decipher mentioned this issue Jul 5, 2022
Closed
21 tasks
Decipher added a commit that referenced this issue Jul 6, 2022
@Decipher
fix(#464): update breadcrumb story setup
5cd85d5
Decipher added a commit that referenced this issue Jul 6, 2022
@Decipher
fix(#464): update druxt stories
c830bd4
Decipher added a commit that referenced this issue Jul 6, 2022
@Decipher
chore(#464): update story description
07cae78
Decipher added a commit that referenced this issue Jul 6, 2022
@Decipher
chore(#464): add changeset
a4ded60
Decipher added a commit that referenced this issue Jul 6, 2022
@Decipher
chore(#464): fix broken test
a38a932
Decipher added a commit that referenced this issue Jul 6, 2022
@Decipher
chore(#464): update test data
14184fa
Decipher added a commit that referenced this issue Jul 6, 2022
@Decipher
fix(#464): fix failing test
6722b55
Decipher added a commit that referenced this issue Jul 6, 2022
@Decipher
chore(#464): update nuxt storybook to latest
0b506fd
Decipher added a commit that referenced this issue Jul 6, 2022
@Decipher
fix(#464): fix breadcrumb story
d953880
Decipher added a commit that referenced this issue Jul 6, 2022
@Decipher
fix(#464): fix issues with nuxt/storybook 4.3.0 (#467)
45e14b8 
* fix(#464): update breadcrumb story setup

* fix(#464): update druxt stories

* chore(#464): update story description

* chore(#464): add changeset

* chore(#464): fix broken test

* chore(#464): update test data

* fix(#464): fix failing test

* chore(#464): update nuxt storybook to latest

* fix(#464): fix breadcrumb story
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Issue is currently blocked bug Something isn't working
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

fix(#464): fix issues with nuxt/storybook 4.3.0 druxt/druxt.js
1 participant
@Decipher