Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(#328): throw Error on router errors #329

Merged
merged 1 commit into from
Oct 10, 2021

Conversation

Decipher
Copy link
Member

@Decipher Decipher commented Oct 10, 2021

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Screenshots/Media:

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2021

🦋 Changeset detected

Latest commit: e693074

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
druxt-router Minor
druxt-blocks Patch
druxt-breadcrumb Patch
druxt-entity Patch
druxt-site Patch
druxt-views Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 10, 2021

Codecov Report

Merging #329 (e693074) into develop (897dcbc) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #329   +/-   ##
========================================
  Coverage    96.59%   96.59%           
========================================
  Files           89       89           
  Lines         2819     2820    +1     
  Branches       595      594    -1     
========================================
+ Hits          2723     2724    +1     
  Misses          85       85           
  Partials        11       11           
Impacted Files Coverage Δ
packages/router/src/router.js 99.01% <ø> (-0.01%) ⬇️
packages/router/src/stores/router.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 897dcbc...e693074. Read the comment docs.

@Decipher Decipher force-pushed the feature/328-router_errors branch from 1fccffb to 0ad945b Compare October 10, 2021 09:50
@Decipher Decipher force-pushed the feature/328-router_errors branch from 0ad945b to e693074 Compare October 10, 2021 09:59
@Decipher Decipher merged commit c7b267a into develop Oct 10, 2021
@Decipher Decipher deleted the feature/328-router_errors branch October 10, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update router error message/behaviour.
1 participant