Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#419): Fix errors in storybook #421

Merged
merged 4 commits into from
Jan 14, 2022
Merged

Conversation

Decipher
Copy link
Member

@Decipher Decipher commented Jan 14, 2022

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Screenshots/Media:

@Decipher Decipher added the enhancement New feature or request label Jan 14, 2022
@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2022

🦋 Changeset detected

Latest commit: 5226ebf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
druxt-blocks Patch
druxt Patch
druxt-entity Patch
druxt-views Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #421 (5226ebf) into develop (933e02f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #421   +/-   ##
========================================
  Coverage    96.86%   96.87%           
========================================
  Files           88       88           
  Lines         2907     2908    +1     
  Branches       638      639    +1     
========================================
+ Hits          2816     2817    +1     
  Misses          83       83           
  Partials         8        8           
Impacted Files Coverage Δ
packages/entity/src/components/DruxtEntity.vue 100.00% <ø> (ø)
packages/blocks/src/components/DruxtBlock.vue 100.00% <100.00%> (ø)
packages/druxt/src/components/DruxtModule.vue 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 933e02f...5226ebf. Read the comment docs.

@Decipher Decipher changed the title [#419] Fix errors in storybook fix(#419): Fix errors in storybook Jan 14, 2022
@Decipher Decipher merged commit d7e92b2 into develop Jan 14, 2022
@Decipher Decipher deleted the feature/419-storybook_bugs branch January 14, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid handler for event "value": got undefined
1 participant