Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#158): add multilingual support #422

Merged
merged 57 commits into from
May 17, 2022
Merged

Conversation

Decipher
Copy link
Member

@Decipher Decipher commented Jan 15, 2022

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Added prefix support to the DruxtClient and DruxtStore for multilingual support
  • Added langcode prop and lang computed prop to DruxtModule
  • Added langcode prefix support to DruxtBlockRegion isVisible method
  • Added langcode prefix support to DruxtBreadcrumb to prevent duplicate home entries
  • Added langcode support to DruxtMenu
  • Added langcode prefix support to DruxtRouter and added lagncode prefixed wildcard routing
  • Added langcode prefixed API proxy entries
  • All Module components updated for langcode support
  • Resolves Add multilingual support #158

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Screenshots/Media:

@Decipher Decipher added the needs work Issue or PR needs more work still label Jan 15, 2022
@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2022

🦋 Changeset detected

Latest commit: 6b76b23

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
druxt Minor
druxt-router Minor
druxt-blocks Minor
druxt-menu Minor
druxt-entity Minor
druxt-breadcrumb Minor
druxt-site Minor
druxt-views Minor
druxt-schema Patch
druxt-test-utils Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Decipher Decipher force-pushed the feature/158-multilingual branch 2 times, most recently from bdf11e5 to 209862b Compare March 30, 2022 03:40
@Decipher Decipher force-pushed the feature/158-multilingual branch 2 times, most recently from b49f861 to 11d9ab3 Compare April 19, 2022 01:59
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #422 (6b76b23) into develop (5514fa3) will increase coverage by 0.26%.
The diff coverage is 97.91%.

@@             Coverage Diff             @@
##           develop     #422      +/-   ##
===========================================
+ Coverage    97.13%   97.39%   +0.26%     
===========================================
  Files           89       89              
  Lines         2965     3031      +66     
  Branches       663      693      +30     
===========================================
+ Hits          2880     2952      +72     
+ Misses          76       70       -6     
  Partials         9        9              
Impacted Files Coverage Δ
packages/blocks/src/mixins/block.js 100.00% <ø> (ø)
packages/entity/src/components/DruxtField.vue 97.89% <ø> (ø)
packages/entity/src/mixins/entity.js 100.00% <ø> (ø)
packages/entity/src/nuxtModule.js 100.00% <ø> (ø)
...rc/components/blocks/DruxtBlockSystemMenuBlock.vue 100.00% <ø> (ø)
packages/menu/src/mixins/menu.js 88.88% <ø> (ø)
packages/router/src/mixins/router.js 88.88% <ø> (ø)
packages/site/src/components/DruxtSite.vue 100.00% <ø> (ø)
packages/site/src/mixins/site.js 100.00% <ø> (ø)
packages/site/src/nuxtModule.js 100.00% <ø> (ø)
... and 40 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Decipher Decipher force-pushed the feature/158-multilingual branch 4 times, most recently from 374dde0 to 89d7eb0 Compare May 12, 2022 22:23
@Decipher Decipher marked this pull request as ready for review May 12, 2022 23:48
@Decipher Decipher removed the needs work Issue or PR needs more work still label May 15, 2022
@Decipher Decipher merged commit be21952 into develop May 17, 2022
@Decipher Decipher deleted the feature/158-multilingual branch May 17, 2022 02:19
@Decipher
Copy link
Member Author

Huzzah, it's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multilingual support
3 participants