Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#433): add path prop to DruxtBreadcrumb #434

Merged
merged 3 commits into from
Feb 3, 2022

Conversation

Decipher
Copy link
Member

@Decipher Decipher commented Feb 3, 2022

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

Screenshots/Media:

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2022

🦋 Changeset detected

Latest commit: 17ac2ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
druxt-breadcrumb Minor
druxt-site Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #434 (17ac2ea) into develop (2b49d1c) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #434      +/-   ##
===========================================
- Coverage    96.87%   96.81%   -0.07%     
===========================================
  Files           88       89       +1     
  Lines         2916     2921       +5     
  Branches       639      642       +3     
===========================================
+ Hits          2825     2828       +3     
- Misses          83       85       +2     
  Partials         8        8              
Impacted Files Coverage Δ
...ages/breadcrumb/src/components/DruxtBreadcrumb.vue 100.00% <100.00%> (ø)
packages/druxt/src/components/DruxtDebug.vue 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b49d1c...17ac2ea. Read the comment docs.

@Decipher Decipher merged commit 0436de4 into develop Feb 3, 2022
@Decipher Decipher deleted the feature/433-breadcrumb_path branch February 3, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to set breadcrumb path
1 participant