Chore: alert when multiple conmmands were selected #179
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OdenTakashi this looks good to me, but can you rebase? There was a new PR merged in to fix CI. |
OdenTakashi
force-pushed
the
chore/alert_when_multiple_conmmands_were_selected
branch
from
31da0e7 to
915394f
Compare
|
@drwl |
OdenTakashi
force-pushed
the
chore/alert_when_multiple_conmmands_were_selected
branch
from
5e0123f to
449933e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for developing such a awesome gem. 👍
In this PR, I have worked on the TODO comment at the following location:
annotaterb/lib/annotate_rb/parser.rb
Line 84 in 7746f54
Description
I have added an alert message indicating that only one command will be executed when multiple commands are specified.
Additionally, the following section did not enter the conditional branch, so I moved it above
if @commands.any?.If you have any better approaches, I would appreciate your suggestions.