Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an evolution from the approach in #100. With this change, settings may be specified with a
cloneable
option, e.g.This makes it possible to provide “rich” config values that carry their own configuration interface.
In the example above,
ComponentDirs
could provide its own API for adding component dirs and configuring aspects of their behavior at the same time. By being passed to the setting along withcloneable: true
, dry-configurable will ensure the setting's values are cloned along with the setting at all the appropriate times (seeSetting#initialize_copy
).As the example here suggests, this change is in service of dry-system providing a new ”rich”
component_dirs
setting, providing an API like this: