Take default value from a keyword argument #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waiting-for-dev
force-pushed
the
waiting-for-dev/default_keyword_argument
branch
from
9bace47 to
94029e1
Compare
timriley
approved these changes
May 17, 2021
There was a problem hiding this comment.
Looks good to me, @waiting-for-dev!
If you wanted to put co-author information on the commit message, that might be fun, but I'm good either way really, just happy to see the work moving forward :)
I also think the duplication of test setup for the logger is fine, this is just for deprecation messages after all, and these tests should go away in the release where we remove the deprecations.
Happy for you to merge when you're ready. Looking forward to figuring out a release plan from here!
waiting-for-dev
force-pushed
the
waiting-for-dev/processor_keyword_argument
branch
from
73945a7 to
b118da0
Compare
Base automatically changed from
waiting-for-dev/processor_keyword_argument
to
master
May 17, 2021 15:27
waiting-for-dev
force-pushed
the
waiting-for-dev/default_keyword_argument
branch
from
94029e1 to
c1893ee
Compare
|
Thanks @timriley. I added you as a co-author 🙂 However, it seems that the tests are failing for ruby 3.0, I'll try to fix it tomorrow. |
waiting-for-dev
force-pushed
the
waiting-for-dev/default_keyword_argument
branch
2 times, most recently
from
36b90c5 to
9333ef9
Compare
From now on, the default value for a setting must be provided through the `default:` keyword argument. I.e.: ```ruby setting :db, default: 'mysql://localhost/dev' ``` Providing it as a positional argument is still supported but deprecated. Co-authored-by: Tim Riley <tim@riley.id.au>
waiting-for-dev
force-pushed
the
waiting-for-dev/default_keyword_argument
branch
from
9333ef9 to
06ab2f0
Compare
|
Fixed for 3.0 and merged 🚀 |
waiting-for-dev
added a commit
that referenced
this pull request
Aug 11, 2021
jodosha
pushed a commit
that referenced
this pull request
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From now on, the default value for a setting must be provided through
the
default:keyword argument. I.e.:Providing it as a positional argument is still supported but deprecated.
@timriley this is basically your code on #86 (so feel free to add you as commit author 😅 )
@solnic , continuing from #110 (comment), extracting the deprecation expectations is a bit tricky because of global state + the need to rewind IO before asserting. So I just repeated the code for now. We could just remove the expectation altogether, as it's not that important and it'll be removed when version 1.0 is released.