-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for custom config classes #136
Conversation
446f7d6
to
5bc4da4
Compare
5bc4da4
to
4c11e39
Compare
@timriley bump :) |
@solnic This is looking good to me so far! Feels like it'd be worth following through in this PR to support custom config classes on nested settings, because without that, this single "outer" custom config class may be of fairly limited value (i.e. I know we couldn't port Hanami::Action's configuration to vanilla dry-configurable at that point; we'd need the custom nested config classes too). |
@timriley you mean something like this: setting :db do
setting :host, config: MyHostConfig do
# ...
end
end ?? |
@solnic yep, exactly this! |
@timriley OK I'll make it possible in this PR |
4c11e39
to
7f518de
Compare
@timriley I called the option |
7f518de
to
442ae46
Compare
442ae46
to
297d8c8
Compare
No description provided.