Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for latest dry configurable #356

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Update for latest dry configurable #356

merged 1 commit into from
Sep 8, 2021

Conversation

timriley
Copy link
Member

No description provided.

@timriley timriley requested a review from solnic as a code owner May 24, 2021 12:42
@timriley timriley force-pushed the update-for-latest-dry-configurable branch from 0ede5f9 to 0d10c1e Compare May 24, 2021 12:58
@timriley timriley changed the title Update for latest dry configurable and dry-core equalizer Update for latest dry configurable May 24, 2021
solnic
solnic reviewed May 25, 2021
View reviewed changes
Copy link
Member

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same case as with dry-validation - I think it'd be good to make it work with both versions of dry-configurable.

@solnic solnic force-pushed the update-for-latest-dry-configurable branch from 0471911 to 1a058e7 Compare June 29, 2021 09:04
@solnic
Copy link
Member

solnic commented Jun 29, 2021

so, the patch won't work because once you start nesting setting the execution context changes, gah

@timriley timriley mentioned this pull request Aug 5, 2021
Closed
@timriley timriley force-pushed the update-for-latest-dry-configurable branch from 1a058e7 to b205ab9 Compare August 5, 2021 11:50
@timriley timriley force-pushed the update-for-latest-dry-configurable branch from b205ab9 to fa9501b Compare September 8, 2021 12:52
@timriley
Copy link
Member Author

timriley commented Sep 8, 2021 •
edited
Loading

This one turned out not to need any kind of special patching now that we made sure the upcoming dry-configurable deprecations covered all possible cases (tested in dry-rb/dry-configurable#120).

@timriley timriley merged commit 29d8029 into master Sep 8, 2021
@timriley timriley deleted the update-for-latest-dry-configurable branch September 8, 2021 13:14
@timriley timriley mentioned this pull request Oct 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solnic solnic solnic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timriley @solnic