Make compatibility fixes to support a future dry-configurable 0.13.0 release (for 0.19 series for releases) #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we still have this override method in place, we need to have it work for both current and upcoming versions of dry-configurable. Using ruby2_keywords for this ensures this works even when we're passing "real" keyword arguments for different params signatures in Ruby 3.0 and beyond.
Provide an explicit hash literal for the default value (i.e. by adding curly braces) rather than depending on Ruby's implicit "convert keyword arguments to a hash" behavior, which will not work when the dry-configurable `setting` method changes to accept proper keyword arguments in a future release.
|
@solnic @flash-gordon Are you happy for me to merge this and release it as 0.19.2? |
solnic
approved these changes
Aug 23, 2021
timriley
deleted the
fix-configurable-setting-override-for-future-api-changes-0.19
branch
timriley
changed the title
timriley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes 2 changes:
ruby2_keywordsfor our override of dry-configurable'ssettingmethod, to make sure it will still work to delegate to the original when provided "real" keyword arguments in newer RubiesWith these changes in place, the dry-system test suite passes against both dry-configurable 0.12.1 (the latest released version) as well as the master branch (intended for release as 0.13.0), on both Ruby versions 3.0.1 and 2.7.3.
To prepare for the upcoming dry-configurable release (which is being planned for at dry-rb/dry-configurable#120), we need to: