Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:589 Transfer the options when invoking hints #652

Merged
merged 1 commit into from
Jun 18, 2020

Conversation

sirfilip
Copy link

#589 proposed fix

Copy link
Member

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There are only a couple of minor style fixes needed before I can merge this in 🙂

@solnic
Copy link
Member

solnic commented Jun 18, 2020

Don't worry about failing CI. This is a problem with configuration that I need to fix in master.

@solnic
Copy link
Member

solnic commented Jun 18, 2020

Please rebase and squash the commits - this should fix the CI and keep the history clean.

@sirfilip sirfilip force-pushed the 589-proposed-solution branch from 5613865 to 5f835a9 Compare June 18, 2020 08:38
@solnic solnic merged commit 2679a6d into dry-rb:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants