Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actually install the version that we're saying we're installing #321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeffory-orrok
Copy link

@jeffory-orrok jeffory-orrok commented May 22, 2021

Include the package name and version in the yarn and npm install commands.

Fixes issue #320

Include the package name and version in the `yarn` and `npm install` commands.
@jeffory-orrok
Copy link
Author

Sorry, I don't have time at the moment to come up with a test for this :-/

@elsassph
Copy link

@ds300 can we get that fix in? That doesn't work for us too - for some reason it's installing the wrong version in the temp directory and generate incorrect patches.

@orta
Copy link
Collaborator

orta commented Sep 28, 2022

I don't think I get what's happening when it is not working - can someone talk me through how we end up with a bad version?

I've never added a specifier after install (and it's not a feature in yarn 3 for example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants