Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have parser methods return nodes instead of unique_ptrs #45

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Have parser methods return nodes instead of unique_ptrs #45

merged 1 commit into from
Feb 4, 2024

Conversation

PiJoules
Copy link
Collaborator

No description provided.

@PiJoules PiJoules requested a review from dsLeks January 26, 2024 18:45
dsLeks
dsLeks approved these changes Feb 4, 2024
View reviewed changes
Copy link
Owner

@dsLeks dsLeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dsLeks dsLeks merged commit 6d2f132 into main Feb 4, 2024
2 checks passed
@dsLeks dsLeks deleted the have-parser-methods-return-nodes branch February 4, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsLeks dsLeks dsLeks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PiJoules @dsLeks