Fix String Literals to Handle Newline. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiJoules
reviewed
Mar 13, 2024
test.cpp
Outdated
Comment on lines
46
to
47
| std::string expectedStr = "Hello World"; | ||
| expectedStr.insert(0, 1, '\n'); |
There was a problem hiding this comment.
Similar to above, this can be one single string with a newline at the start:
constexpr std::string_view kExpectedStr = "\nHello World";
I was only using gtest last night. Before that, I installed gtest to fix compilation errors. My llvm which was version 14 seem to work fine last night. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts newline representation to its character form.