Skip to content

Commit

Permalink
refac(back): fluidattacks#1351 simplify builtin name
Browse files Browse the repository at this point in the history
- Rename from deployContainerImage to deployContainer

Signed-off-by: Daniel Salazar <podany270895@gmail.com>
  • Loading branch information
dsalaza4 committed Jul 26, 2024
1 parent 4e2e7ab commit fb94869
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 21 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ concurrency:
cancel-in-progress: true
group: ${{ github.actor }}
jobs:
deployContainerImage_makesLatestAmd64:
deployContainer_makesLatestAmd64:
if: ${{ github.repository == 'fluidattacks/makes' }}
runs-on: ubuntu-latest
permissions:
Expand All @@ -15,8 +15,8 @@ jobs:
GITHUB_ACTOR: ${{ github.actor }}
GITHUB_TOKEN: ${{ github.token }}
with:
args: sh -c "chown -R root:root /github/workspace && nix-env -if . && m . /deployContainerImage/makesLatestAmd64"
deployContainerImage_makesLatestArm64:
args: sh -c "chown -R root:root /github/workspace && nix-env -if . && m . /deployContainer/makesLatestAmd64"
deployContainer_makesLatestArm64:
if: ${{ github.repository == 'fluidattacks/makes' }}
runs-on: buildjet-2vcpu-ubuntu-2204-arm
permissions:
Expand All @@ -29,8 +29,8 @@ jobs:
GITHUB_ACTOR: ${{ github.actor }}
GITHUB_TOKEN: ${{ github.token }}
with:
args: sh -c "chown -R root:root /github/workspace && nix-env -if . && m . /deployContainerImage/makesLatestArm64"
deployContainerImage_makesPinnedAmd64:
args: sh -c "chown -R root:root /github/workspace && nix-env -if . && m . /deployContainer/makesLatestArm64"
deployContainer_makesPinnedAmd64:
if: ${{ github.repository == 'fluidattacks/makes' }}
runs-on: ubuntu-latest
permissions:
Expand All @@ -43,8 +43,8 @@ jobs:
GITHUB_ACTOR: ${{ github.actor }}
GITHUB_TOKEN: ${{ github.token }}
with:
args: sh -c "chown -R root:root /github/workspace && nix-env -if . && m . /deployContainerImage/makesPinnedAmd64"
deployContainerImage_makesPinnedArm64:
args: sh -c "chown -R root:root /github/workspace && nix-env -if . && m . /deployContainer/makesPinnedAmd64"
deployContainer_makesPinnedArm64:
if: ${{ github.repository == 'fluidattacks/makes' }}
runs-on: buildjet-2vcpu-ubuntu-2204-arm
permissions:
Expand All @@ -57,7 +57,7 @@ jobs:
GITHUB_ACTOR: ${{ github.actor }}
GITHUB_TOKEN: ${{ github.token }}
with:
args: sh -c "chown -R root:root /github/workspace && nix-env -if . && m . /deployContainerImage/makesPinnedArm64"
args: sh -c "chown -R root:root /github/workspace && nix-env -if . && m . /deployContainer/makesPinnedArm64"
releaseGitHub:
if: ${{ github.repository == 'fluidattacks/makes' }}
runs-on: ubuntu-latest
Expand Down
12 changes: 6 additions & 6 deletions docs/src/api/builtins/deploy.md
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ Note that positional arguments (`[ "1" "2" "3" ]` in this case)
will be appended to the end of `command`
before sending the job to Batch.

## deployContainerImage
## deployContainer

Deploy a set of container images
in [OCI Format](https://github.com/opencontainers/image-spec)
Expand All @@ -143,7 +143,7 @@ please read the `makeContainerImage` reference.

Types:

- deployContainerImage:
- deployContainer:
- images (`attrsOf imageType`): Optional.
Definitions of container images to deploy.
Defaults to `{ }`.
Expand Down Expand Up @@ -195,7 +195,7 @@ Example:
};
};

deployContainerImage = {
deployContainer = {
images = {
nginxDockerHub = {
credentials = {
Expand Down Expand Up @@ -235,19 +235,19 @@ Example:
=== "Invocation DockerHub"

```bash
DOCKER_HUB_USER=user DOCKER_HUB_PASS=123 m . /deployContainerImage/nginxDockerHub
DOCKER_HUB_USER=user DOCKER_HUB_PASS=123 m . /deployContainer/nginxDockerHub
```

=== "Invocation GitHub"

```bash
GITHUB_ACTOR=user GITHUB_TOKEN=123 m . /deployContainerImage/makesLatest
GITHUB_ACTOR=user GITHUB_TOKEN=123 m . /deployContainer/makesLatest
```

=== "Invocation GitLab"

```bash
CI_REGISTRY_USER=user CI_REGISTRY_PASSWORD=123 m . /deployContainerImage/makesGitLab
CI_REGISTRY_USER=user CI_REGISTRY_PASSWORD=123 m . /deployContainer/makesGitLab
```

## deployTerraform
Expand Down
2 changes: 1 addition & 1 deletion makes.nix
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
enable = true;
target = "github.com/fluidattacks/makes";
};
deployContainerImage = {
deployContainer = {
images = {
makesLatestAmd64 = {
attempts = 3;
Expand Down
2 changes: 1 addition & 1 deletion src/args/agnostic.nix
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ let
calculateScorecard = import ./calculate-scorecard/default.nix self;
chunks = import ./chunks/default.nix self;
computeOnAwsBatch = import ./compute-on-aws-batch/default.nix self;
deployContainerImage = import ./deploy-container-image/default.nix self;
deployContainer = import ./deploy-container-image/default.nix self;
deployNomad = import ./deploy-nomad/default.nix self;
deployTerraform = import ./deploy-terraform/default.nix self;
inherit (__nixpkgs__.lib.strings) escapeShellArg;
Expand Down
10 changes: 5 additions & 5 deletions src/evaluator/modules/deploy-container-image/default.nix
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{ __toModuleOutputs__, deployContainerImage, ... }:
{ __toModuleOutputs__, deployContainer, ... }:
{ config, lib, ... }:
let
makeOutput = name: args: {
name = "/deployContainerImage/${name}";
value = deployContainerImage {
name = "/deployContainer/${name}";
value = deployContainer {
inherit (args) attempts;
inherit (args) credentials;
containerImage = args.src;
Expand All @@ -16,7 +16,7 @@ let
};
in {
options = {
deployContainerImage = {
deployContainer = {
images = lib.mkOption {
default = { };
type = lib.types.attrsOf (lib.types.submodule (_: {
Expand Down Expand Up @@ -46,6 +46,6 @@ in {
};
};
config = {
outputs = __toModuleOutputs__ makeOutput config.deployContainerImage.images;
outputs = __toModuleOutputs__ makeOutput config.deployContainer.images;
};
}

0 comments on commit fb94869

Please sign in to comment.