Rework Tokenizer #254
Merged
Rework Tokenizer #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheConstructor
force-pushed
the
feature/sane-tokenizer
branch
from
0648250 to
fc159ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reworked Tokenizer, trying to remove the repeated splitting, as the elements were all already there and utilizing the built-in
StringSplitOptions.RemoveEmptyEntries.In doing this I found, that the current implementation would return a string twice, if it does not contain delimiters and the tokenizer is asked to return the delimiters. This is cause by
Tokenize()not returning or settingtempstrto empty afterif (tempstr.IndexOfAny(_delimiters.ToCharArray()) < 0 && tempstr.Length > 0), so that it is added again by the lastifin that method.