Subscribe/Unsubscribe from blog alerts #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asrient
requested changes
Dec 24, 2020
dscblog/models.py
Outdated
| @@ -403,7 +404,8 @@ def get_topics(self): | |||
|
|
|||
| def get_obj_min(self): | |||
| obj = {'title': self.title, 'img_url': self.img_url, 'blog_id': self.id, 'blog_url': self.get_url(), | |||
| 'is_published': self.is_published, 'modified_on': self.modified_on, 'published_on': self.published_on, 'author': self.author.get_profile_min()} | |||
| 'is_published': self.is_published, 'modified_on': self.modified_on, 'published_on': self.published_on, | |||
| 'author': self.author.get_profile_min(), 'is_subscribed': self.is_subscribed} | |||
There was a problem hiding this comment.
Don't add is_subscribed in obj_min since this property should only be used by the author. If u need this property, access it separately whenever needed
Riken-Shah
force-pushed
the
notification-blog
branch
from
3d8606e to
242fa02
Compare
asrient
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this feature, blog authors can subscribe/unsubscribe to alerts he/she will receive for that particular blog.
It will avoid alerts such as
Reaction,Comment, andComment Replyif the author has unsubscribed from that blog.