Added separate login-banner and footer #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baishakhi9931
commented
Jan 1, 2021
baishakhi9931
commented
asrient
requested changes
Jan 3, 2021
Comment on lines
+61
to
+63
| background: #D0D8DB; | ||
| padding-top: 60px; | ||
| padding-bottom: 40px; |
Comment on lines
+66
to
+68
| textarea { | ||
| resize: none; | ||
| } |
There was a problem hiding this comment.
it's not required for our footer and might interfere with other elements unintentionally
Comment on lines
+3
to
+4
| <script src="https://kit.fontawesome.com/a076d05399.js"></script> | ||
| <script defer src="https://use.fontawesome.com/releases/v5.0.13/js/all.js" integrity="sha384-xymdQtn1n3lH2wcu0qhcdaOpQwyoarkgLVxC/wZ5q7h9gHtxICrpcaSUfygqZGOe" crossorigin="anonymous"></script> |
There was a problem hiding this comment.
don't use this library since we are not using it elsewhere. Instead, put the icons in the static/icons directory.
Comment on lines
+5
to
+6
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <body> |
There was a problem hiding this comment.
Invalid html, body and meta tags are already defined in the base file
Comment on lines
+38
to
+42
| <a class="social-button facebook" href="https://facebook.com/dsciem" target="_blank"><i class="fab fa-facebook-f"></i></a> | ||
| <a class="social-button twitter" href="https://twitter.com/dsc_iem" target="_blank"><i class="fab fa-twitter"></i></a> | ||
| <a class="social-button linkedin" href="https://www.linkedin.com/company/dsciem" target="_blank"><i class="fab fa-linkedin"></i></a> | ||
| <a class="social-button youtube" href="http://www.youtube.com/c/DSCIEM" target="_blank"><i class="fab fa-youtube"></i></a> | ||
| <a class="social-button instagram" href="https://instagram.com/dsc_iem" target="_blank"><i class="fab fa-instagram"></i></a> |
There was a problem hiding this comment.
use img elements or set background-image
| <a class="social-button instagram" href="https://instagram.com/dsc_iem" target="_blank"><i class="fab fa-instagram"></i></a> | ||
| </div> | ||
| <p> | ||
| <a href="https://github.com/dsc-iem/blog"><b>Help us make this website better :) </b></a> |
There was a problem hiding this comment.
"Help us make this website better >" no
Comment on lines
+54
to
+57
| * { | ||
| margin: 0; | ||
| padding: 0; | ||
| } |
| </div> | ||
| </div> | ||
| </footer> | ||
| </body> |
| Unleash your creativity <br/> with DSC IEM</h1> <h7> | ||
| <div style="padding-top: 15px;padding-left: 30px;padding-right: 0px;">Read and share ideas from independent voices, world-class <br/> publications, and experts from around the globe. Everyone's <br/> welcome. </h7> <br/> </div> <div style="padding-top: 15px;padding-left: 30px;padding-right: 0px;"> | ||
| <a class="hd_opt btn btn-bordered" href="/accounts/login" style="width: 100px ;">Log In</a> | ||
| </div> |
There was a problem hiding this comment.
the top level div is not closed.
add another </div> at the end
| left: 60px; | ||
| top:60px; | ||
| margin-top:20px; | ||
| background: radial-gradient(91.06% 87.79% at 7.31% 5.58%, #96FF8B 0%, #A5FFC2 24.18%, #92FFF2 45.35%, #FFCAEF 74.34%, #FFE654 100%); |
There was a problem hiding this comment.
make the background colors darker (maybe a different set but darker) for dark mode.
use it like:
[data-theme="dark"] .elem {
background-color: ...
}Do this inside style tags or css files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.