Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveDirectoryDsc: Update pipeline paths trigger #599

Merged
merged 2 commits into from
Apr 25, 2020
Merged

ActiveDirectoryDsc: Update pipeline paths trigger #599

merged 2 commits into from
Apr 25, 2020

Conversation

johlju
Copy link
Member

@johlju johlju commented Apr 21, 2020 •
edited by X-Guardian
Loading

Pull Request (PR) description

  • Fixed the pipeline paths trigger.

This is now according to the docs here https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/github?view=azure-devops&tabs=yaml#paths

This Pull Request (PR) fixes the following issues

None.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju
Copy link
Member Author

johlju commented Apr 21, 2020 •
edited
Loading

Hang on, got old DscResources.Tests in there :/

@johlju johlju requested a review from X-Guardian April 21, 2020 18:45
@johlju
Copy link
Member Author

johlju commented Apr 21, 2020

Ready for review!

@johlju johlju added the on hold The issue or pull request has been put on hold by a maintainer. label Apr 22, 2020
@johlju
Copy link
Member Author

johlju commented Apr 22, 2020

Waiting to verify this change in DscResource.Common.

@johlju johlju added needs review The pull request needs a code review. and removed on hold The issue or pull request has been put on hold by a maintainer. labels Apr 23, 2020
@johlju
Copy link
Member Author

johlju commented Apr 23, 2020

This works in DscResource.Common. It runs master on merge, and it does not run master when merging the changelog after a release.

X-Guardian
X-Guardian approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@X-Guardian X-Guardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@X-Guardian X-Guardian added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Apr 24, 2020
@X-Guardian X-Guardian merged commit 01657f2 into dsccommunity:master Apr 25, 2020
@X-Guardian X-Guardian removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Apr 25, 2020
This was referenced Apr 26, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@PlagueHO PlagueHO mentioned this pull request May 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@X-Guardian X-Guardian X-Guardian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johlju @X-Guardian