Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pipeline to Publish Code Coverage - Fixes #255 #256

Merged
merged 2 commits into from
Apr 10, 2021

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Apr 10, 2021

Pull Request (PR) description

This PR adds build coverage reporting to build pipeline. It also updates the build to use Sampler.GitHubTasks.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing when you have time?


This change is Reviewable

@PlagueHO PlagueHO changed the title Update Pipeline to Publish Code Coverage Update Pipeline to Publish Code Coverage - Fixes #255 Apr 10, 2021
@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Apr 10, 2021
@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@20c185c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             main   #256   +/-   ##
=====================================
  Coverage        ?    84%           
=====================================
  Files           ?      7           
  Lines           ?    929           
  Branches        ?      0           
=====================================
  Hits            ?    786           
  Misses          ?    143           
  Partials        ?      0           

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PlagueHO)

@johlju johlju removed the needs review The pull request needs a code review. label Apr 10, 2021
@johlju johlju merged commit 9aecbed into dsccommunity:main Apr 10, 2021
@PlagueHO PlagueHO deleted the Issue-255 branch April 10, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Code Coverage Reporting Update Sampler Build Tasks
2 participants