-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WindowsEventLog MaximumSizeInBytes needs IsEnabled Parameter #349
Comments
Hi @ChristophHannappel - thanks for raising this and good point. This should be documented and also an example should be included. I've marked as Help Wanted for now because I'm completely snowed under till beginning of Dec. |
I can help :) Since the knowledge is fresh. This is my first time, should i try a pull request on the wiki md file? Or does it work different? |
Hi @ChristophHannappel - would love the help. Just submit a PR against the README.MD in the |
I'm working on another issue with WindowsEventLog (#355) so I'll update the README.MD to include this when I submit the PR. |
@ChristophHannappel I submitted the PR and waiting for the code review process. I rewrote part of the code so you won't need to configure 'IsEnabled' in order to achieve what you're looking for. Your first resource example will work with this release. |
The Ressource WindowsEventLog doesn't do anything with
MaximumSizeInBytes
if the ParameterIsEnabled
is not set.I think that behavior is based on the GUI, where the MaximumSizeInBytes Control gets deactivated if you disable the log.
I'd be nice if the Documentation would state, that you need the Parameter
IsEnabled
set to$true
in order to useMaximumSizeInBytes
.This Ressouce does nothing:
But this does:
The text was updated successfully, but these errors were encountered: