Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WindowsEventLog MaximumSizeInBytes needs IsEnabled Parameter #349

Closed
ChristophHannappel opened this issue Nov 5, 2020 · 5 comments · Fixed by #359
Closed

WindowsEventLog MaximumSizeInBytes needs IsEnabled Parameter #349

ChristophHannappel opened this issue Nov 5, 2020 · 5 comments · Fixed by #359
Labels
documentation The issue is related to documentation only. help wanted The issue is up for grabs for anyone in the community.

Comments

@ChristophHannappel
Copy link

The Ressource WindowsEventLog doesn't do anything with MaximumSizeInBytes if the Parameter IsEnabled is not set.
I think that behavior is based on the GUI, where the MaximumSizeInBytes Control gets deactivated if you disable the log.
I'd be nice if the Documentation would state, that you need the Parameter IsEnabled set to $true in order to use MaximumSizeInBytes.

This Ressouce does nothing:

        WindowsEventLog 'Microsoft SharePoint 2019\Operational'
        {
            LogName =  'Microsoft-SharePoint Products-Shared/Operational'
            MaximumSizeInBytes = 10240KB
        }

But this does:

        WindowsEventLog 'Microsoft SharePoint 2019\Operational'
        {
            LogName =  'Microsoft-SharePoint Products-Shared/Operational'
            IsEnabled = $true
            MaximumSizeInBytes = 10240KB
        }
@PlagueHO PlagueHO added documentation The issue is related to documentation only. help wanted The issue is up for grabs for anyone in the community. labels Nov 7, 2020
@PlagueHO
Copy link
Member

PlagueHO commented Nov 7, 2020

Hi @ChristophHannappel - thanks for raising this and good point. This should be documented and also an example should be included. I've marked as Help Wanted for now because I'm completely snowed under till beginning of Dec.

@ChristophHannappel
Copy link
Author

ChristophHannappel commented Nov 7, 2020

I can help :) Since the knowledge is fresh. This is my first time, should i try a pull request on the wiki md file? Or does it work different?

@PlagueHO
Copy link
Member

PlagueHO commented Nov 7, 2020

Hi @ChristophHannappel - would love the help. Just submit a PR against the README.MD in the source\DSCResources\DSC_WindowsEventLog folder and add a new example to the source\Examples\Resources folder. The Wiki gets updated automatically from those files.

@cohdjn
Copy link
Contributor

cohdjn commented Feb 5, 2021

I'm working on another issue with WindowsEventLog (#355) so I'll update the README.MD to include this when I submit the PR.

@cohdjn
Copy link
Contributor

cohdjn commented Feb 12, 2021

@ChristophHannappel I submitted the PR and waiting for the code review process. I rewrote part of the code so you won't need to configure 'IsEnabled' in order to achieve what you're looking for. Your first resource example will work with this release.

PlagueHO added a commit that referenced this issue Apr 9, 2021
WindowsEventLog: Multiple Updates - Fixes #355, #349, #338, #229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation The issue is related to documentation only. help wanted The issue is up for grabs for anyone in the community.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants