ScheduledTask: Add support for Group Managed Service Accounts #174
Conversation
…led tasks with Group Managed Service Accounts
…tDsc into ScheduledTask-gMSA-support
Codecov Report
@@ Coverage Diff @@
## dev #174 +/- ##
===================================
+ Coverage 90% 90% +<1%
===================================
Files 7 7
Lines 715 724 +9
===================================
+ Hits 648 657 +9
Misses 67 67 |
|
@PlagueHO do you have time to review this one? This one seems it falls under the same functionality as the PR and the comment dsccommunity/xPSDesiredStateConfiguration#441 (comment) |
|
How did I miss this! @danielboth - are you able to fix the merge conflicts? Sorry about the delay. I'll get onto reviewing this. |
…tDsc into ScheduledTask-gMSA-support
|
Hi @PlagueHO, I pulled the latest dev to get my branch up to date a few days ago, no merge conflicts fortunately :). Can you continue the review? |
There was a problem hiding this comment.
Really great stuff @danielboth - sorry about taking so long. Pretty much faultless - just the tiniest of style nitpicks in the tests. I'll merge as soon as they're done. Thanks again!
Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @danielboth)
Tests/Unit/MSFT_ScheduledTask.Tests.ps1, line 1733 at r1 (raw file):
Context 'When a scheduled task is created using a Group Managed Service Account' {
Can you remove this blank line here?
Tests/Unit/MSFT_ScheduledTask.Tests.ps1, line 1803 at r1 (raw file):
} It 'Test should return true if the task is in desired state and given gMSA user in DOMAIN\User$ format' {
Can you change to 'Should return true when test is called if...' - We try to make It descriptions start with 'Should'
Tests/Unit/MSFT_ScheduledTask.Tests.ps1, line 1809 at r1 (raw file):
$testParameters.ExecuteAsGMSA = 'gMSA$@domain.fqdn' It 'Test should return true if the task is in desired state and given gMSA user in UPN format' {
Can you change to 'Should return true when test is called if the task...' - We try to make It descriptions start with 'Should'
There was a problem hiding this comment.
Reviewed 5 of 6 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @PlagueHO)
Tests/Unit/MSFT_ScheduledTask.Tests.ps1, line 1733 at r1 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
Can you remove this blank line here?
Done.
Tests/Unit/MSFT_ScheduledTask.Tests.ps1, line 1803 at r1 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
Can you change to 'Should return true when test is called if...' - We try to make
Itdescriptions start with 'Should'
Done.
Tests/Unit/MSFT_ScheduledTask.Tests.ps1, line 1809 at r1 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
Can you change to 'Should return true when test is called if the task...' - We try to make
Itdescriptions start with 'Should'
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
|
@PlagueHO - sorry if you're not the person to ask, but I was just curious if there is a planned release to PSGallery where this feature will be available. Looks like last version of 4.1.0.0 was prior to this pull request being closed. If this information can be found elsewhere, I apologize. Please feel free to point me in the direction. Thanks! |
|
Hi @ImMattAsh - the latest version in the PSGallery is 6.0.0.0 I think (there was also a 5.0.0.0, 5.1.0.0, 5.2.0.0): https://www.powershellgallery.com/packages/ComputerManagementDsc/6.0.0.0. Might have been a PS Gallery glitch? The best way to see what has been released month to month in the DSC Resource kit is by looking here: https://blogs.msdn.microsoft.com/powershell/tag/dsc-resource-kit/ |
|
@PlagueHO - fwiw, it was no glitch - I missed that the name changed from xComputerManagement to ComputerManagmentDsc - completely my mistake. Thanks again, and sorry for the confusion. |
|
Ah right! Of course. Glad all working and no worries at all. |
Pull Request (PR) description
This PR enables the use of Group Managed Service Accounts in the ScheduledTask resource. It enables the user to setup a scheduled task using a AD ServiceAccount and will set the task to 'Run whether user is logged on or not'.
This Pull Request (PR) fixes the following issues:
Fixes #111
Task list:
This change is