-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get-LocalizationData
: Refactor command
#109
Get-LocalizationData
: Refactor command
#109
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
===================================
- Coverage 92% 91% -1%
===================================
Files 37 37
Lines 645 656 +11
===================================
+ Hits 594 602 +8
- Misses 51 54 +3
|
Merging this after review by @lbrauns in issue #108 (comment). Are there any issues that someone encounters, let me know in a new issue and I look into it. |
Tests could be improved, but they are better (more coverage) that when I started at least. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 5 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johlju)
This refactor was tested with SqlServerDsc's integration tests and seem to work just fine. Will send out a full release later today or tomorrow. |
Pull Request (PR) description
Get-LocalizedData
used a steppable pipeline (proxies
Import-LocalizedData
), that wasremoved since it was not possible to use the command in a pipeline.
It just made it more complex and harder to debug. There are more
debug messages added to hopefully simplify solving some hard to find
edge cases bugs.
This Pull Request (PR) fixes the following issues
Get-LocalizationData
: Cannot find the Windows PowerShell data file #108Get-LocalizationData
: There is an issue when using this command on non-en-US
locales #74Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
DSC Community Testing Guidelines.
This change is