Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get-LocalizationData: Refactor command #109

Merged
merged 5 commits into from
Jan 20, 2024

Conversation

johlju
Copy link
Member

@johlju johlju commented Jan 20, 2024

Pull Request (PR) description

  • Updated the pipelines files for resolving dependencies.
  • Get-LocalizedData
    • Refactored to simplify execution and debugging. The command previously
      used a steppable pipeline (proxies Import-LocalizedData), that was
      removed since it was not possible to use the command in a pipeline.
      It just made it more complex and harder to debug. There are more
      debug messages added to hopefully simplify solving some hard to find
      edge cases bugs.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated for all new/changed functions.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See
    DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (9d4c630) 92% compared to head (9d7e534) 91%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #109   +/-   ##
===================================
- Coverage    92%    91%   -1%     
===================================
  Files        37     37           
  Lines       645    656   +11     
===================================
+ Hits        594    602    +8     
- Misses       51     54    +3     
Files Coverage Δ
source/Public/Get-LocalizedData.ps1 80% <80%> (-2%) ⬇️

@johlju
Copy link
Member Author

johlju commented Jan 20, 2024

Merging this after review by @lbrauns in issue #108 (comment). Are there any issues that someone encounters, let me know in a new issue and I look into it.

@johlju
Copy link
Member Author

johlju commented Jan 20, 2024

Tests could be improved, but they are better (more coverage) that when I started at least. 🙂

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 5 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit a83ec13 into dsccommunity:main Jan 20, 2024
10 of 11 checks passed
@johlju johlju deleted the f/refactor-Get-LocalizedData branch January 20, 2024 20:58
@johlju
Copy link
Member Author

johlju commented Jan 21, 2024

This refactor was tested with SqlServerDsc's integration tests and seem to work just fine. Will send out a full release later today or tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant