Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlServerDsc: Remove type [System.Management.Automation.Credential()] from examples #1003

Closed
johlju opened this issue Jan 7, 2018 · 0 comments · Fixed by #1005
Closed

SqlServerDsc: Remove type [System.Management.Automation.Credential()] from examples #1003

johlju opened this issue Jan 7, 2018 · 0 comments · Fixed by #1005
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Jan 7, 2018

Details of the scenario you tried and the problem that is occurring:
Since we not supporting PowerShell 4.0 we could remove all of the occurrences of [System.Management.Automation.Credential()]. It's used in all examples for example. It's also in some resources, but this issue is for removing them from the examples.

The following

        [Parameter(Mandatory = $true)]
        [System.Management.Automation.PSCredential]
        [System.Management.Automation.Credential()]
        $SqlAdministratorCredential

would be changed to

        [Parameter(Mandatory = $true)]
        [System.Management.Automation.PSCredential]
        $SqlAdministratorCredential

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone. labels Jan 7, 2018
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jan 7, 2018
@johlju
Changes to SqlServerDsc
c91e6d6 
- Style changes in all examples, removing type [System.Management.Automation.Credential()]
  from credential parameters (issue dsccommunity#1003), and renamed the credential parameter so it is
  not using abbreviation.
@johlju johlju mentioned this issue Jan 7, 2018
Merged
5 tasks
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jan 7, 2018
@johlju
Changes to SqlServerDsc
02b131d 
- Style changes in all examples, removing type [System.Management.Automation.Credential()]
  from credential parameters (issue dsccommunity#1003), and renamed the credential parameter so it is
  not using abbreviation.
johlju added a commit that referenced this issue Jan 9, 2018
@johlju
SqlServerDsc: Fix style of examples (#1005)
e8eaf91 
- Changes to SqlServerDsc
  - Style changes in all examples, removing type [System.Management.Automation.Credential()]
    from credential parameters (issue #1003), and renamed the credential parameter so it is not
    using abbreviation.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlServerDsc: Fix style of examples johlju/SqlServerDsc
1 participant
@johlju