Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlSetup: SecurityMode parameter is not clear how to use #1010

Closed
johlju opened this issue Jan 10, 2018 · 1 comment · Fixed by #1058
Closed

SqlSetup: SecurityMode parameter is not clear how to use #1010

johlju opened this issue Jan 10, 2018 · 1 comment · Fixed by #1058
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Jan 10, 2018 •
edited
Loading

Details of the scenario you tried and the problem that is occurring:
The parameter SecurityMode is not clear how to use. It does not say that the only supported value is 'SQL', neither is it using a validate set so this can be set to anything, without throwing.

Parameter description should also be update to mention that the parameter enables mixed mode authentication in SQL Server.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. easy fix good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Jan 10, 2018
@johlju
Copy link
Member Author

johlju commented Jan 20, 2018

We should add the value 'Windows' to the parameter as well, even if there is no other code changes needed to get only Windows authentication, but having this value in the validate set would be more accurate since the parameter SecurityMode returns 'Windows' from the Get-TargetResource function.

@TraGicCode TraGicCode mentioned this issue Mar 4, 2018
Merged
5 tasks
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Mar 6, 2018
johlju pushed a commit that referenced this issue Mar 6, 2018
@TraGicCode @johlju
SqlSetup: Clearly document and validate SecurityMode Parameter (#1058)
29f2fc4 
- Changes to SqlSetup
  - Clarify usage of 'SecurityMode' along with adding parameter
    validations for the only 2 supported values (issue #1010).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlSetup: Clearly document and validate SecurityMode Parameter
1 participant
@johlju