Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when dropping a login using the resource xSqlServerLogin #105

Closed
johlju opened this issue Aug 14, 2016 · 2 comments
Closed

Error when dropping a login using the resource xSqlServerLogin #105

johlju opened this issue Aug 14, 2016 · 2 comments
Labels
bug The issue is a bug.

Comments

@johlju
Copy link
Member

johlju commented Aug 14, 2016

When dropping a login by saying state should be 'Absent' the login will be removed, but an error will occur. This is because a validation occur after the drop. That validation does improperly validation on LoginType when state is absent.
@johlju
Copy link
Member Author

johlju commented Aug 14, 2016

I have a fix for this that will remove the validation of LoginType since the resource can't handle changing between login types anyway. And a login name is always unique. SQL logins can use 'John' but Windows logins must use '<DOMAIN|COMPUTER>\John'.

johlju added a commit to johlju/SqlServerDsc that referenced this issue Aug 14, 2016
@johlju
Resolves issue dsccommunity#105
faa2d54
@johlju johlju mentioned this issue Aug 14, 2016
Merged
@johlju
Copy link
Member Author

johlju commented Aug 14, 2016

This will be fixed when PR #106 is merged

johlju added a commit to johlju/SqlServerDsc that referenced this issue Aug 17, 2016
@johlju
Resolves issue dsccommunity#105
844cebd
@kwirkykat kwirkykat added bug The issue is a bug. in progress The issue is being actively worked on by someone. labels Aug 19, 2016
johlju added a commit to johlju/SqlServerDsc that referenced this issue Aug 19, 2016
@johlju
Resolves issue dsccommunity#105
b2e856f
johlju added a commit to johlju/SqlServerDsc that referenced this issue Aug 20, 2016
@johlju
Resolves issue dsccommunity#105
48c2592
johlju added a commit to johlju/SqlServerDsc that referenced this issue Aug 22, 2016
@johlju
Resolves issue dsccommunity#105
9414a36
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Apr 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kwirkykat @johlju