Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlSetup: Missing Configuration Feature/Options : Service Startup Type (SQLENGINE/AGT,AS,IS,RS) #1165

Closed
mdaniou opened this issue Jun 30, 2018 · 5 comments · Fixed by #1184
Closed

SqlSetup: Missing Configuration Feature/Options : Service Startup Type (SQLENGINE/AGT,AS,IS,RS) #1165

mdaniou opened this issue Jun 30, 2018 · 5 comments · Fixed by #1184
Assignees
@mdaniou
Labels
enhancement The issue is an enhancement request.

Comments

@mdaniou
Copy link
Contributor

mdaniou commented Jun 30, 2018

Details of the scenario you tried and the problem that is occurring

This issue is created to bring some improvements to the SqlSetup DSC Configuration. The idea is to report all the missing options in the resource to allow the installation of all the features and to use all the options available in the SQL Server installer.

Option to add to the DSC Resource :

/SQLSVCSTARTUPTYPE
/AGTSVCSTARTUPTYPE
/ASSVCSTARTUPTYPE
/ISSVCStartupType
/RSSVCStartupType

The DSC configuration that is using the resource (as detailed as possible)

SqlSetup

Version of the operating system and PowerShell the target node is running

Windows Server 2012/2012R2/2016

SQL Server edition and version the target node is running

SQL Server 2012/2014/2016/2017

Exception for Report Service :
SQL Server 2012/2014/2016

What SQL Server PowerShell modules, and which version, are present on the target node.

Most recent version

Version of the DSC module you're using, or write 'dev' if you're using current dev branch

Most recent version
@mdaniou mdaniou mentioned this issue Jun 30, 2018
Closed
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jun 30, 2018
@mdaniou
Copy link
Contributor Author

mdaniou commented Jun 30, 2018

Hi @johlju

I am working on this card, could you please assign it to me and move it to In progress ?
Also the label Help Wanted could be removed then. Up to you.

Thx in advance !

@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jun 30, 2018
@johlju
Copy link
Member

johlju commented Jun 30, 2018

Done! Thank you for this! 😃

@Francois-Rousseau Francois-Rousseau mentioned this issue Jul 5, 2018
Open
@mdaniou
Copy link
Contributor Author

mdaniou commented Jul 14, 2018

PR created : #1184

@mdaniou mdaniou mentioned this issue Jul 17, 2018
Merged
9 tasks
@mdaniou
Copy link
Contributor Author

mdaniou commented Aug 16, 2018 •
edited
Loading

Hi @johlju

I try to configure the integration tests to implement my changes when possible. I have updated the config MSFT_SqlSetup_InstallDatabaseEngineNamedInstanceAsSystem_Config by adding the following :

SqlSvcStartupType     = 'Automatic'
AgtSvcStartupType     = 'Automatic'

Now I need to modify the test file and at line 267 I find this :

$resourceCurrentState.BrowserSvcStartupType | Should -BeNullOrEmpty

The config has

BrowserSvcStartupType = 'Automatic'

Shouldn't we have in the test file :

$resourceCurrentState.BrowserSvcStartupType | Should -Be 'Automatic'

I am missing something here ...

@johlju
Copy link
Member

johlju commented Aug 17, 2018 •
edited
Loading

If the Get-TargetResource is returning $resourceCurrentState, and you expect $resourceCurrentState.BrowserSvcStartupType to contain 'Automatic', then, you are correct, using $resourceCurrentState.BrowserSvcStartupType | Should -Be 'Automatic' sounds correct.

johlju pushed a commit that referenced this issue Aug 30, 2018
@mdaniou @johlju
SqlSetup: Add missing service StartupType (DBE,AGT,AS,IS,RS) (#1184)
3714325 
- Changes to SqlSetup
  - Added new parameters to allow to define the startup types for the Sql Engine
    service, the Agent service, the Analysis service and the Integration Service.
    The new optional parameters are respectively SqlSvcStartupType, AgtSvcStartupType,
    AsSvcStartupType, IsSvcStartupType and RsSvcStartupType (issue #1165).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdaniou mdaniou

Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlSetup: Add missing properties: Service Startup Type (SQLENGINE/AGT,AS,IS,RS)
2 participants
@johlju @mdaniou