Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the CONTRIBUTING.md files together #1227

Closed
johlju opened this issue Sep 20, 2018 · 0 comments · Fixed by #1576
Closed

Move the CONTRIBUTING.md files together #1227

johlju opened this issue Sep 20, 2018 · 0 comments · Fixed by #1576
Labels
documentation The issue is related to documentation only.

Comments

@johlju
Copy link
Member

johlju commented Sep 20, 2018

There are contributing documents in both the .github folder, in the root of the repo and in the README.md. The CONTRIBUTING.md in the rootof the repo should be moved to the CONTRIBUTING.md in the .github folder. Unless it is possible to remove the file in the .github folder and GitHUb points to the one in the root of the folder. It would be best to have the CONTRIBUTING.md in the root of the folder if it works.

image
@johlju johlju added help wanted The issue is up for grabs for anyone in the community. documentation The issue is related to documentation only. labels Sep 20, 2018
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jun 26, 2020
@johlju johlju mentioned this issue Jun 26, 2020
Merged
9 tasks
johlju added a commit that referenced this issue Jul 1, 2020
@johlju
SqlServerDsc: Documentation updates (#1576)
1833285 
- SqlServerDsc
  - Remove the file `.github/CONTRIBUTION.md` as it no longer filled any
    purpose as GitHub will find the CONTRIBUTION.md in the root folder
    directly now (issue #1227).
  - The documentation in CONTRIBUTING.md has been somewhat updated.
  - Update documentation around design pattern for accounts that does not
    use passwords (issue #378)
    and (issue #1230).
  - Updating the Integration Test README.md to better explain what the
    integration tests for SqlSetup, SqlRSSetup, and SqlRS does (issue #1315).
- SqlAGReplica
  - Update documentation with a requirement for SqlServer in certain circumstances
    (issue #1033).
- SqlRSSetup
  - There was a typo in the error message that was thrown when not passing
    either the `Edition` or `ProductKey` that could be misleading (issue #1386).
  - Updated the parameter descriptions for the parameters `Edition` and
    `ProductKey` that they are mutually exclusive (issue #1386).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation The issue is related to documentation only.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlServerDsc: Documentation updates johlju/SqlServerDsc
1 participant
@johlju