Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlServerEndpoint : Should let us choose the owner #1251

Closed
mdaniou opened this issue Nov 8, 2018 · 3 comments · Fixed by #1271
Closed

SqlServerEndpoint : Should let us choose the owner #1251

mdaniou opened this issue Nov 8, 2018 · 3 comments · Fixed by #1271
Labels
enhancement The issue is an enhancement request.

Comments

@mdaniou
Copy link
Contributor

mdaniou commented Nov 8, 2018 •
edited
Loading

Details of the scenario you tried and the problem that is occurring

I am configuring the endpoint and realise that its owner is the default one.
It seems to be advised that the owner would be 'sa'

I think that the resource should allow us to define that.

Suggested solution to the issue

The object Microsoft.SqlServer.Management.Smo.Endpoint has the property 'Owner' so I assume than adding a block like this one would do the job :

if ($PSBoundParameters.ContainsKey('Owner'))
{
$endpointObject.Owner = $Owner
}

Version and build of PowerShell the target node is running

12.1.0.0
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Nov 12, 2018
@johlju
Copy link
Member

johlju commented Nov 12, 2018

Sounds like a good addition to the resource! 🙂

@mdaniou
Copy link
Contributor Author

mdaniou commented Jan 21, 2019

@johlju : I am working on this one.

@johlju
Copy link
Member

johlju commented Jan 21, 2019

Awesome. Looking forward to the PR. Once the PR is sent in I will label this as in progress.

@mdaniou mdaniou mentioned this issue Jan 23, 2019
Merged
9 tasks
johlju pushed a commit that referenced this issue Jan 25, 2019
@mdaniou @johlju
SqlServerEndpoint : Add parameter "Owner" (#1271)
f601a9d 
- Changes to SqlServerEndpoint
  - Add the optional parameter Owner. The default owner remains the login used
  for the creation of the endpoint (issue #1251).
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlServerEndpoint : Add parameter "Owner"
2 participants
@johlju @mdaniou