Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlReplication: Replace Get-SqlServerMajorVersion #1408

Closed
johlju opened this issue Jul 18, 2019 · 0 comments · Fixed by #1612
Closed

SqlReplication: Replace Get-SqlServerMajorVersion #1408

johlju opened this issue Jul 18, 2019 · 0 comments · Fixed by #1612
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Jul 18, 2019

We should replace the function Get-SqlServerMajorVersion with the helper function Get-SqlInstanceMajorVersion in SqlServerDsc.Common to reduce code.

The functions are the same.
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. labels Jul 18, 2019
@johlju johlju changed the title SqlServerReplication: Replace Get-SqlServerMajorVersion SqlReplication: Replace Get-SqlServerMajorVersion Aug 17, 2020
johlju added a commit to johlju/SqlServerDsc that referenced this issue Aug 17, 2020
@johlju
SqlReplication: Remove duplicate function (issue dsccommunity#1408)
62e7b1c
@johlju johlju mentioned this issue Aug 17, 2020
Merged
9 tasks
johlju added a commit that referenced this issue Aug 19, 2020
@johlju
SqlReplication: Remove duplicate function (#1612)
4a425ea 
- SqlServerDsc
  - Updated code formatting using latest release of PSScriptAnalyzer.
  - The URLs in the CHANGELOG.md that was pointing to issues is now
    referencing the new repository name and URL.
- SqlServerDsc.Common
  - The helper function `Get-SqlInstanceMajorVersion` no longer have a default
    value for parameter **InstanceName** since the parameter is mandatory
    and it was never used.
- SqlReplication
  - The resource are now using the helper function `Get-SqlInstanceMajorVersion`
    (issue #1408).
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlReplication: Remove duplicate function johlju/SqlServerDsc
1 participant
@johlju