Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerLogin: Set default database #1474

Closed
bozho opened this issue Mar 11, 2020 · 1 comment · Fixed by #1485
Closed

SqlServerLogin: Set default database #1474

bozho opened this issue Mar 11, 2020 · 1 comment · Fixed by #1485
Labels
enhancement The issue is an enhancement request.

Comments

@bozho
Copy link
Contributor

bozho commented Mar 11, 2020

Details of the scenario you tried and the problem that is occurring

SqlServerLogin resource currently does not support setting the default database for logins.

Verbose logs showing the problem

N/A

Suggested solution to the issue

Add an optional DefaultDatabase parameter.

The DSC configuration that is used to reproduce the issue (as detailed as possible)

N/A

SQL Server edition and version the target node is running

N/A

SQL Server PowerShell modules present on the target node

N/A

The operating system the target node is running

N/A

Version and build of PowerShell the target node is running

Name                           Value                                                                                   
----                           -----                                                                                   
PSVersion                      5.1.14393.3471                                                                          
PSEdition                      Desktop                                                                                 
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}                                                                 
BuildVersion                   10.0.14393.3471                                                                         
CLRVersion                     4.0.30319.42000                                                                         
WSManStackVersion              3.0                                                                                     
PSRemotingProtocolVersion      2.3                                                                                     
SerializationVersion           1.1.0.1                                                                                 

Version of the DSC module that was used

Name         Version  Path                                                                              
----         -------  ----                                                                              
SqlServerDsc 13.0.0.0 C:\Program Files\WindowsPowerShell\Modules\SqlServerDsc\13.0.0.0\SqlServerDsc.psd1

I'm happy to provide a patch for this, just wanted to check if there are any caveats/problems I should be aware of...

@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Mar 13, 2020
@johlju
Copy link
Member

johlju commented Mar 13, 2020

Sounds like a new property in the existing resource, so can't see any problems or caveats, at least not now. 🙂

bozho added a commit to bozho/SqlServerDsc that referenced this issue Mar 26, 2020
bozho added a commit to bozho/SqlServerDsc that referenced this issue Mar 27, 2020
bozho added a commit to bozho/SqlServerDsc that referenced this issue Mar 27, 2020
bozho added a commit to bozho/SqlServerDsc that referenced this issue Mar 31, 2020
bozho added a commit to bozho/SqlServerDsc that referenced this issue Apr 8, 2020
bozho added a commit to bozho/SqlServerDsc that referenced this issue Apr 10, 2020
johlju pushed a commit that referenced this issue Apr 11, 2020
- SqlServerLogin
  - Added `DefaultDatabase` parameter (issue #1474]).
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants