Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlAlias: Allow creating same alias with two different server locations #1502

Closed
johlju opened this issue Apr 16, 2020 · 0 comments · Fixed by #1503
Closed

SqlAlias: Allow creating same alias with two different server locations #1502

johlju opened this issue Apr 16, 2020 · 0 comments · Fixed by #1503
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. bug The issue is a bug.

Comments

@johlju
Copy link
Member

johlju commented Apr 16, 2020

The parameter ServerName is using the type qualifier Key which make it possible to add to instances of SqlAlias with the same name but pointing to two different server locations. This means that the first instance will have 'mydbinstance.local' and then the second instance will change it to something else it will result in a ping-pong behavior where both instances tries to change the configuration back.
@johlju johlju added bug The issue is a bug. in progress The issue is being actively worked on by someone. breaking change When used on an issue, the issue has been determined to be a breaking change. labels Apr 16, 2020
@johlju johlju mentioned this issue Apr 16, 2020
Merged
9 tasks
johlju added a commit that referenced this issue Apr 26, 2020
@johlju
BREAKING CHANGE: SqlServerDsc: Make parameter ServerName non-mandatory (
d18827b 
#1503)

- SqlAgentAlert
  - The parameter `ServerName` now throws when passing an empty string or
    null value (part of issue #319).
- SqlAgentFailsafe
  - The parameter `ServerName` now throws when passing an empty string or
    null value (part of issue #319).
- SqlAgentOperator
  - The parameter `ServerName` now throws when passing an empty string or
    null value (part of issue #319).
- SqlAlias
  - BREAKING CHANGE: The parameter `ServerName` is now non-mandatory to
    prevent ping-pong behavior ([issue #1502](#1502)).
    The `ServerName` is not returned as an empty string when the protocol is
    Named Pipes.
- SqlAlwaysOnService
  - BREAKING CHANGE: The parameter `ServerName` is now non-mandatory and
    defaults to `$env:COMPUTERNAME` (issue #319).
  - Normalize parameter descriptive text for default values.
- SqlDatabase
  - BREAKING CHANGE: The parameter `ServerName` is now non-mandatory and
    defaults to `$env:COMPUTERNAME` (issue #319).
  - Normalize parameter descriptive text for default values.
- SqlDatabaseDefaultLocation
  - BREAKING CHANGE: The parameter `ServerName` is now non-mandatory and
    defaults to `$env:COMPUTERNAME` (issue #319).
  - Normalize parameter descriptive text for default values.
- SqlDatabasePermission
  - BREAKING CHANGE: The parameter `ServerName` is now non-mandatory and
    defaults to `$env:COMPUTERNAME` (issue #319).
  - Normalize parameter descriptive text for default values.
- SqlDatabaseRecoveryModel
  - BREAKING CHANGE: The parameter `ServerName` is now non-mandatory and
    defaults to `$env:COMPUTERNAME` (issue #319).
  - Normalize parameter descriptive text for default values.
- SqlDatabaseRole
  - BREAKING CHANGE: The parameter `ServerName` is now non-mandatory and
    defaults to `$env:COMPUTERNAME` (issue #319).
  - Normalize parameter descriptive text for default values.
- SqlDatabaseUser
  - BREAKING CHANGE: The parameter `ServerName` is now non-mandatory and
    defaults to `$env:COMPUTERNAME` (issue #319).
  - Normalize parameter descriptive text for default values.
- SqlRs
  - Fix typo in the schema parameter `SuppressRestart` description
    and in the parameter description in the `README.md`.
- SqlServerConfiguration
  - BREAKING CHANGE: The parameter `ServerName` is now non-mandatory and
    defaults to `$env:COMPUTERNAME` (issue #319).
  - Normalize parameter descriptive text for default values.
- SqlServerDatabaseMail
  - Normalize parameter descriptive text for default values.
  - The parameter `ServerName` now throws when passing an empty string or
    null value (part of issue #319).
- SqlServerEndpoint
  - Normalize parameter descriptive text for default values.
  - The parameter `ServerName` now throws when passing an empty string or
    null value (part of issue #319).
- SqlServerEndpointPermission
  - BREAKING CHANGE: The parameter `ServerName` is now non-mandatory and
    defaults to `$env:COMPUTERNAME` (issue #319).
  - Normalize parameter descriptive text for default values.
- SqlServerEndpointState
  - The parameter `ServerName` now throws when passing an empty string or
    null value (part of issue #319).
- SqlServerLogin
  - BREAKING CHANGE: The parameter `ServerName` is now non-mandatory and
    defaults to `$env:COMPUTERNAME` (issue #319).
  - Normalize parameter descriptive text for default values.
- SqlServerPermission
  - The parameter `ServerName` now throws when passing an empty string or
    null value (part of issue #319).
- SqlServerRole
  - BREAKING CHANGE: The parameter `ServerName` is now non-mandatory and
    defaults to `$env:COMPUTERNAME` (issue #319).
  - Normalize parameter descriptive text for default values.
- SqlServiceAccount
  - BREAKING CHANGE: The parameter `ServerName` is now non-mandatory and
    defaults to `$env:COMPUTERNAME` (issue #319).
  - Normalize parameter descriptive text for default values.
- SqlSetup
  - Update integration tests to correctly detect sysadmins because of changes
    to the build worker.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. bug The issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING CHANGE: SqlServerDsc: Make parameter ServerName non-mandatory johlju/SqlServerDsc
1 participant
@johlju