Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlServerDsc: Do not mark 'ready for merge' PRs as stale #1504

Closed
johlju opened this issue Apr 19, 2020 · 0 comments · Fixed by #1511
Closed

SqlServerDsc: Do not mark 'ready for merge' PRs as stale #1504

johlju opened this issue Apr 19, 2020 · 0 comments · Fixed by #1511
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Apr 19, 2020

When a PR is labelled with 'ready for merge' it should not be marked as stale.

SqlServerDsc/.github/stale.yml

Lines 11 to 14 in 2f60d0f

exemptLabels:
- needs review
- on hold
- waiting for CLA pass

We should add 'ready for merge' label to the exempt list.
@johlju johlju added enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub help wanted The issue is up for grabs for anyone in the community. in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Apr 19, 2020
@johlju johlju mentioned this issue Apr 26, 2020
Merged
9 tasks
johlju added a commit that referenced this issue May 4, 2020
@johlju
SqlServerProtocol: New resource proposal (#1511)
fab9419 
- SqlServerDsc
  - Added new resource SqlServerProtocol (issue #1377).
  - When a PR is labelled with 'ready for merge' it is no longer being
    marked as stale if the PR is not merged for 30 days (for example it is
    dependent on something else) (issue #1504).
  - Updated the CI pipeline to use latest version of the module ModuleBuilder.
- SqlServerDsc.Common
  - The helper function `Restart-SqlService` was improved to handle Failover
    Clusters better. Now the SQL Server service will only be taken offline
    and back online again if the service is online to begin with.
  - The helper function `Restart-SqlServer` learned the new parameter
    `OwnerNode`. The parameter `OwnerNode` takes an array of Cluster node
    names. Using this parameter the cluster group will only be taken
    offline and back online if the cluster group owner is one specified
    in this parameter.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlServerProtocol: New resource proposal johlju/SqlServerDsc
1 participant
@johlju