Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServerDsc: Fix minor review comments #1881

Closed
johlju opened this issue Mar 25, 2023 · 0 comments · Fixed by #1887
Closed

SqlServerDsc: Fix minor review comments #1881

johlju opened this issue Mar 25, 2023 · 0 comments · Fixed by #1887
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Mar 25, 2023

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)


azure-pipelines.yml line 194 at r1 (raw file):

              Remove-Module -Name CommonTestHelper
            name: removeSqlServerModule
            displayName: 'Remove SqlServer module'

Can be fixed in another PR.

Suggestion:

'Clean CI worker'

azure-pipelines.yml line 296 at r1 (raw file):

              Remove-Module -Name CommonTestHelper
            name: removeSqlServerModule
            displayName: 'Remove SqlServer module'

Can be fixed in another PR.

Suggestion:

'Clean CI worker'

source/Public/Import-SqlDscPreferredModule.ps1 line 113 at r1 (raw file):

            $modulePathMachine = [System.String] [System.Environment]::GetEnvironmentVariable('PSModulePath', 'Machine')

            $modulePath = $modulePathSession + ';'  + $modulePathUser + ';' + $modulePathMachine

Can be fixed in another PR.

Suggestion:

$modulePath = $modulePathSession, $modulePathUser, $modulePathMachine -join ';'

Originally posted by @johlju in #1877 (review)

@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Mar 25, 2023
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant