-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqlRS: Add new integration test jobs #1877
SqlRS: Add new integration test jobs #1877
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1877 +/- ##
====================================
Coverage 92% 92%
====================================
Files 85 85
Lines 7631 7640 +9
====================================
+ Hits 7029 7038 +9
Misses 602 602
|
e416e22
to
c80067f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johlju)
azure-pipelines.yml
line 194 at r1 (raw file):
Remove-Module -Name CommonTestHelper name: removeSqlServerModule displayName: 'Remove SqlServer module'
Can be fixed in another PR.
Suggestion:
'Clean CI worker'
azure-pipelines.yml
line 296 at r1 (raw file):
Remove-Module -Name CommonTestHelper name: removeSqlServerModule displayName: 'Remove SqlServer module'
Can be fixed in another PR.
Suggestion:
'Clean CI worker'
source/Public/Import-SqlDscPreferredModule.ps1
line 113 at r1 (raw file):
$modulePathMachine = [System.String] [System.Environment]::GetEnvironmentVariable('PSModulePath', 'Machine') $modulePath = $modulePathSession + ';' + $modulePathUser + ';' + $modulePathMachine
Can be fixed in another PR.
Suggestion:
$modulePath = $modulePathSession, $modulePathUser, $modulePathMachine -join ';'
Pull Request (PR) description
to be able to test configuring SQL Server Reportings Services using
other values that the default values.
This Pull Request (PR) fixes the following issues
Part of PR #1870 which is required for the tests to pass
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
This change is