Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlRS: Add new integration test jobs #1877

Merged
merged 19 commits into from
Mar 25, 2023

Conversation

johlju
Copy link
Member

@johlju johlju commented Mar 19, 2023

Pull Request (PR) description

  • SqlServerDsc
    • Added a separate integration test jobs for SQL Server Reporting Services
      to be able to test configuring SQL Server Reportings Services using
      other values that the default values.

This Pull Request (PR) fixes the following issues

Part of PR #1870 which is required for the tests to pass

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Mar 19, 2023
@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Merging #1877 (1e07bc4) into main (5efa82d) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #1877   +/-   ##
====================================
  Coverage    92%     92%           
====================================
  Files        85      85           
  Lines      7631    7640    +9     
====================================
+ Hits       7029    7038    +9     
  Misses      602     602           
Flag Coverage Δ
unit 92% <100%> (+<1%) ⬆️
Impacted Files Coverage Δ
source/Public/Import-SqlDscPreferredModule.ps1 100% <100%> (ø)

@johlju johlju force-pushed the f/add-new-integration-test-jobs branch from e416e22 to c80067f Compare March 20, 2023 07:14
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)


azure-pipelines.yml line 194 at r1 (raw file):

              Remove-Module -Name CommonTestHelper
            name: removeSqlServerModule
            displayName: 'Remove SqlServer module'

Can be fixed in another PR.

Suggestion:

'Clean CI worker'

azure-pipelines.yml line 296 at r1 (raw file):

              Remove-Module -Name CommonTestHelper
            name: removeSqlServerModule
            displayName: 'Remove SqlServer module'

Can be fixed in another PR.

Suggestion:

'Clean CI worker'

source/Public/Import-SqlDscPreferredModule.ps1 line 113 at r1 (raw file):

            $modulePathMachine = [System.String] [System.Environment]::GetEnvironmentVariable('PSModulePath', 'Machine')

            $modulePath = $modulePathSession + ';'  + $modulePathUser + ';' + $modulePathMachine

Can be fixed in another PR.

Suggestion:

$modulePath = $modulePathSession, $modulePathUser, $modulePathMachine -join ';'

@johlju johlju merged commit 67aa742 into dsccommunity:main Mar 25, 2023
@johlju johlju deleted the f/add-new-integration-test-jobs branch March 25, 2023 13:42
@johlju johlju removed the needs review The pull request needs a code review. label Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant