Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invoke-SqlDscQuery: Move logic of Invoke-Query into Invoke-SqlDscQuery #1902

Closed
johlju opened this issue Apr 8, 2023 · 0 comments · Fixed by #1906
Closed

Invoke-SqlDscQuery: Move logic of Invoke-Query into Invoke-SqlDscQuery #1902

johlju opened this issue Apr 8, 2023 · 0 comments · Fixed by #1906
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Apr 8, 2023

Currently the command Invoke-SqlDscQuery is a wrapper for Invoke-Query. The logic of Invoke-Query should be moved to Invoke-SqlDscQuery so that Invoke-Query can be removed entirely.
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Apr 8, 2023
@johlju johlju mentioned this issue Apr 10, 2023
Merged
9 tasks
johlju added a commit that referenced this issue Apr 12, 2023
@johlju
SqlServerDsc.Common: Removed the function Invoke-Query (#1906)
2ea2c07 
- SqlServerDsc.Common
  - Removed the function `Invoke-Query`. It is replaced by the command
    `Invoke-SqlDscQuery` (issue #1902).
- SqlServerDsc
  - New public command:
    - `Disconnect-SqlDscDatabaseEngine` - Disconnects from a SQL Server instance
      that was previously connected to using `Connect-SqlDscDatabaseEngine`.
  - New private command:
    - `ConvertTo-RedactedText` - Used to redact sensitive information from
      text that then can be used in console output like verbose messages.
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlServerDsc.Common: Removed the function Invoke-Query johlju/SqlServerDsc
1 participant
@johlju