Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlServerConfiguration: Localization should change to align with HQRM modules #605

Closed
johlju opened this issue Jun 6, 2017 · 0 comments · Fixed by #1021
Closed

SqlServerConfiguration: Localization should change to align with HQRM modules #605

johlju opened this issue Jun 6, 2017 · 0 comments · Fixed by #1021
Assignees
@johlju
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Jun 6, 2017

Details of the scenario you tried and the problem that is occurring:
Resource should use the same method of localization as HQRM modules (PSDscResource). More information in PR #205.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Jun 6, 2017
@johlju johlju changed the title xSQLServerConfiguration: Localization should change to align with HQRM modules SqlServerConfiguration: Localization should change to align with HQRM modules Dec 23, 2017
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Jan 15, 2018
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jan 15, 2018
@johlju
Changes to SqlServerConfiguration
2347fd5 
- Fixed minor typos in comment-based help.
- Now the verbose message say what option is changing and to what value (issue dsccommunity#1014).
- Change the type of the parameter from SInt32 to UInt32.
- Added localization (issue dsccommunity#605).
@johlju johlju mentioned this issue Jan 15, 2018
Merged
5 tasks
johlju added a commit to johlju/SqlServerDsc that referenced this issue Jan 16, 2018
@johlju
Changes to SqlServerConfiguration
fe11e04 
- Fixed minor typos in comment-based help.
- Now the verbose message say what option is changing and to what value (issue dsccommunity#1014).
- Change the type of the parameter from SInt32 to UInt32.
- Added localization (issue dsccommunity#605).
johlju added a commit that referenced this issue Jan 17, 2018
@johlju
SqlServerConfiguration: Added localization and improved verbose messa…
54df342 
…ges (#1021)

- Changes to SqlServerConfiguration
  - Now the verbose message say what option is changing and to what value (issue #1014).
  - Changed the RestartTimeout parameter from type SInt32 to type UInt32.
  - Added localization (issue #605).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johlju johlju

Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlServerConfiguration: Added localization and improved verbose messages johlju/SqlServerDsc
1 participant
@johlju