Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlServerNetwork: Integration test is missing for this resource #751

Closed
johlju opened this issue Aug 13, 2017 · 0 comments · Fixed by #1172
Closed

SqlServerNetwork: Integration test is missing for this resource #751

johlju opened this issue Aug 13, 2017 · 0 comments · Fixed by #1172
Assignees
@johlju
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Aug 13, 2017

Details of the scenario you tried and the problem that is occurring:
We should add an integration test for this resource.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added help wanted The issue is up for grabs for anyone in the community. needs review The pull request needs a code review. enhancement The issue is an enhancement request. and removed needs review The pull request needs a code review. labels Aug 13, 2017
@johlju johlju changed the title xSQLServerNetwork: Integration test is missing for this resource SqlServerNetwork: Integration test is missing for this resource Dec 24, 2017
@johlju johlju mentioned this issue Jul 4, 2018
Merged
9 tasks
@johlju johlju self-assigned this Jul 4, 2018
johlju added a commit that referenced this issue Jul 6, 2018
@johlju
SqlServerNetwork: Refactored to not load assembly from GAC (#1172)
4997ae4 
- Changes to SqlServerDsc
  - Updated helper function Restart-SqlService to have to new optional parameters
    `SkipClusterCheck` and `SkipWaitForOnline`. This was to support more aspects
    of the resource SqlServerNetwork.
- Changes to SqlServerNetwork
  - Refactor SqlServerNetwork to not load assembly from GAC (issue #1151).
  - The resource now supports restarting the SQL Server service when both
    enabling and disabling the protocol.
  - Added integration tests for this resource
    (issue #751).
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Jul 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johlju johlju

Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SqlServerNetwork: Refactored to not load assembly from GAC johlju/SqlServerDsc
1 participant
@johlju