Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlScript: The parameter ServiceInstance should be split to ServerName and InstanceName #925

Closed
johlju opened this issue Dec 1, 2017 · 1 comment · Fixed by #1546
Closed

SqlScript: The parameter ServiceInstance should be split to ServerName and InstanceName #925

johlju opened this issue Dec 1, 2017 · 1 comment · Fixed by #1546
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@johlju
Copy link
Member

johlju commented Dec 1, 2017

Details of the scenario you tried and the problem that is occurring:
To align the SqlScript resource with the work being done renaming parameters in issue #308, the parameter ServiceInstance should be split into two parameters ServerName and InstanceName.

https://github.com/PowerShell/SqlServerDsc/blob/9a1080c4da5d513eb4191388206cf37c16c0a0fd/DSCResources/MSFT_SqlScript/MSFT_SqlScript.schema.mof#L4

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. breaking change When used on an issue, the issue has been determined to be a breaking change. labels Dec 1, 2017
@johlju johlju added the good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub label May 6, 2020
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels May 14, 2020
@johlju johlju mentioned this issue May 14, 2020
Merged
9 tasks
johlju added a commit that referenced this issue May 19, 2020
@johlju
BREAKING CHANGE: SqlScript/SqlScriptQuery: Replaces parameter ServerI…
883013c 
…nstance (#1546)

- SqlScript
  - BREAKING CHANGE: The parameter `ServerInstance` is replaced by the two
    parameters `ServerName` and `InstanceName`. The parameter `InstanceName`
    is the only one mandatory which fixes the issue that it was possible to
    run the same script using different host names (issue #925).
- SqlScriptQuery
  - BREAKING CHANGE: The parameter `ServerInstance` is replaced by the two
    parameters `ServerName` and `InstanceName`. The parameter `InstanceName`
    is the only one mandatory which fixes the issue that it was possible to
    run the same query using different host names (issue #925).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label May 19, 2020
@sql-sith
Copy link

This approach is obviously the better one, but since I need to patch the scripts I use in Amazon Cloud Formation because of this, I wonder: could this be done as a non-breaking change, where there is still an optional ServerInstance parameter? A user could then supply InstanceName only (with ServerName defaulting to localhost?), ServerName and InstanceName, or ServerInstance only. Any other combinations would be prohibited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING CHANGE: SqlScript/SqlScriptQuery: Replaces parameter ServerInstance johlju/SqlServerDsc
2 participants
@sql-sith @johlju