Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: SqlDatabaseOwner: This should be rolled into the SqlDatabase resource #966

Closed
johlju opened this issue Dec 24, 2017 · 0 comments · Fixed by #1542
Closed

BREAKING CHANGE: SqlDatabaseOwner: This should be rolled into the SqlDatabase resource #966

johlju opened this issue Dec 24, 2017 · 0 comments · Fixed by #1542
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Dec 24, 2017 •
edited
Loading

Details of the scenario you tried and the problem that is occurring:
When work was done renaming resources (in issue #851), there was some suggestions that I thought should become separate issues.

One suggestion was that the resource SqlDatabaseOwner should be merged into SqlDatabase resource.

The DSC configuration that is using the resource (as detailed as possible):
n/a

Version of the Operating System, SQL Server and PowerShell the DSC Target Node is running:
n/a

What module (SqlServer or SQLPS) and which version of the module the DSC Target Node is running:
n/a

Version of the DSC module you're using, or 'dev' if you're using current dev branch:
Dev
@johlju johlju added breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request. help wanted The issue is up for grabs for anyone in the community. labels Dec 24, 2017
@johlju johlju changed the title SqlDatabaseOwner: This should be rolled into the SqlDatabase resource BREAKING CHANGE: SqlDatabaseOwner: This should be rolled into the SqlDatabase resource Dec 24, 2017
@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels May 10, 2020
@johlju johlju mentioned this issue May 10, 2020
Merged
9 tasks
johlju added a commit that referenced this issue May 12, 2020
@johlju
BREAKING CHANGE: SqlServerDsc: Deprecate resource SqlDatabaseOwner (#…
554302d 
…1542)

- SqlDatabaseOwner
  - This resource is now deprecated. The functionality is now covered by
    the resources _SqlDatabase_ (issue #966).
- SqlDatabase
  - The property `OwnerName` was added.
  - BREAKING CHANGE: The non-mandatory parameters was removed from the
    function `Get-TargetResource` since they were not needed.
  - BREAKING CHANGE: The properties `CompatibilityLevel` and `Collation`
    are now only enforced if the are specified in the configuration.
@johlju johlju removed the in progress The issue is being actively worked on by someone. label May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change When used on an issue, the issue has been determined to be a breaking change. enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BREAKING CHANGE: SqlServerDsc: Deprecate resource SqlDatabaseOwner johlju/SqlServerDsc
1 participant
@johlju